From: "joro@8bytes.org" <joro@8bytes.org>
To: "Vesely, Jan" <Jan.Vesely@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain
Date: Wed, 15 Jun 2016 13:54:07 +0200 [thread overview]
Message-ID: <20160615115406.GF26566@8bytes.org> (raw)
In-Reply-To: <1465487321.7114.0.camel@amd.com>
On Thu, Jun 09, 2016 at 03:48:44PM +0000, Vesely, Jan wrote:
> On Sat, 2016-05-21 at 14:11 -0400, Jan Vesely wrote:
> > From: Jan Vesely <jan.vesely@amd.com>
> >
> > Signed-off-by: Jan Vesely <jan.vesely@amd.com>
> > ---
> > drivers/iommu/amd_iommu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> > index 17c76f2..4ff5e40 100644
> > --- a/drivers/iommu/amd_iommu.c
> > +++ b/drivers/iommu/amd_iommu.c
> > @@ -3016,6 +3016,7 @@ static void protection_domain_free(struct
> > protection_domain *domain)
> >
> > del_domain_from_list(domain);
> >
> > + mutex_destroy(&domain->api_lock);
> > if (domain->id)
> > domain_id_free(domain->id);
> >
>
> ping
Your patches lack commit messages, please add a more detailed
description of what you are fixing and why. Please also add 'Fixes:'
tags when resubmitting. The changes itself look good to me.
Joerg
next prev parent reply other threads:[~2016-06-15 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 18:11 [PATCH 1/2] iommu/amd: Remove entry from the list before freeing it Jan Vesely
2016-05-21 18:11 ` [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain Jan Vesely
[not found] ` <1463854264-26445-2-git-send-email-jan.vesely-kgbqMDwikbSVc3sceRu5cw@public.gmane.org>
2016-06-09 15:48 ` Vesely, Jan
2016-06-15 11:54 ` joro [this message]
[not found] ` <20160615115406.GF26566-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-06-15 17:53 ` Vesely, Jan
2016-06-15 20:53 ` Borislav Petkov
[not found] ` <20160615205311.GB19822-fF5Pk5pvG8Y@public.gmane.org>
2016-06-28 16:48 ` Vesely, Jan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615115406.GF26566@8bytes.org \
--to=joro@8bytes.org \
--cc=Jan.Vesely@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).