* [PATCH 1/1] iommu/amd: initialize devid variable before using it
@ 2016-06-26 8:33 Nicolas Iooss
[not found] ` <20160626083329.674-1-nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Iooss @ 2016-06-26 8:33 UTC (permalink / raw)
To: Joerg Roedel; +Cc: iommu, linux-kernel, Nicolas Iooss
Commit 2a0cb4e2d423 ("iommu/amd: Add new map for storing IVHD dev entry
type HID") added a call to DUMP_printk in init_iommu_from_acpi() which
used the value of devid before this variable was initialized.
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
---
drivers/iommu/amd_iommu_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 9e0034196e10..d091defc3426 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -1107,13 +1107,13 @@ static int __init init_iommu_from_acpi(struct amd_iommu *iommu,
break;
}
+ devid = e->devid;
DUMP_printk(" DEV_ACPI_HID(%s[%s])\t\tdevid: %02x:%02x.%x\n",
hid, uid,
PCI_BUS_NUM(devid),
PCI_SLOT(devid),
PCI_FUNC(devid));
- devid = e->devid;
flags = e->flags;
ret = add_acpi_hid_device(hid, uid, &devid, false);
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20160626083329.674-1-nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org>]
* Re: [PATCH 1/1] iommu/amd: initialize devid variable before using it [not found] ` <20160626083329.674-1-nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org> @ 2016-06-27 2:16 ` Wan ZongShun 2016-06-27 11:28 ` Joerg Roedel 1 sibling, 0 replies; 3+ messages in thread From: Wan ZongShun @ 2016-06-27 2:16 UTC (permalink / raw) To: Nicolas Iooss Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel 2016-06-26 16:33 GMT+08:00 Nicolas Iooss <nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org>: > Commit 2a0cb4e2d423 ("iommu/amd: Add new map for storing IVHD dev entry > type HID") added a call to DUMP_printk in init_iommu_from_acpi() which > used the value of devid before this variable was initialized. > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org> > --- > drivers/iommu/amd_iommu_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c > index 9e0034196e10..d091defc3426 100644 > --- a/drivers/iommu/amd_iommu_init.c > +++ b/drivers/iommu/amd_iommu_init.c > @@ -1107,13 +1107,13 @@ static int __init init_iommu_from_acpi(struct amd_iommu *iommu, > break; > } > > + devid = e->devid; > DUMP_printk(" DEV_ACPI_HID(%s[%s])\t\tdevid: %02x:%02x.%x\n", > hid, uid, > PCI_BUS_NUM(devid), > PCI_SLOT(devid), > PCI_FUNC(devid)); > > - devid = e->devid; > flags = e->flags; > Sure, thanks for your patch. This is my fault. > ret = add_acpi_hid_device(hid, uid, &devid, false); > -- > 2.9.0 > -- --- Vincent Wan(Zongshun) www.mcuos.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] iommu/amd: initialize devid variable before using it [not found] ` <20160626083329.674-1-nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org> 2016-06-27 2:16 ` Wan ZongShun @ 2016-06-27 11:28 ` Joerg Roedel 1 sibling, 0 replies; 3+ messages in thread From: Joerg Roedel @ 2016-06-27 11:28 UTC (permalink / raw) To: Nicolas Iooss Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Sun, Jun 26, 2016 at 10:33:29AM +0200, Nicolas Iooss wrote: > Commit 2a0cb4e2d423 ("iommu/amd: Add new map for storing IVHD dev entry > type HID") added a call to DUMP_printk in init_iommu_from_acpi() which > used the value of devid before this variable was initialized. > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org> > --- > drivers/iommu/amd_iommu_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-27 11:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-26 8:33 [PATCH 1/1] iommu/amd: initialize devid variable before using it Nicolas Iooss
[not found] ` <20160626083329.674-1-nicolas.iooss_linux-oWGTIYur0i8@public.gmane.org>
2016-06-27 2:16 ` Wan ZongShun
2016-06-27 11:28 ` Joerg Roedel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).