From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Nate Watterson <nwatters-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/iova: validate iova_domain input to put_iova_domain
Date: Thu, 14 Jul 2016 10:34:20 +0200 [thread overview]
Message-ID: <20160714083420.GR12639@8bytes.org> (raw)
In-Reply-To: <1468435772-27905-1-git-send-email-nwatters-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Wed, Jul 13, 2016 at 02:49:32PM -0400, Nate Watterson wrote:
> Passing a NULL or uninitialized iova_domain into put_iova_domain
> will currently crash the kernel when the unconfigured iova_domain
> data members are accessed. To prevent this from occurring, this patch
> adds a check to make sure that the domain is non-NULL and that the
> domain granule is non-zero. The granule can be used to check if the
> domain was properly initialized because calling init_iova_domain
> with a granule of zero would have already triggered a BUG statement
> crashing the kernel.
Have you seen real crashes happening because of this?
Joerg
next prev parent reply other threads:[~2016-07-14 8:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 18:49 [PATCH] iommu/iova: validate iova_domain input to put_iova_domain Nate Watterson
[not found] ` <1468435772-27905-1-git-send-email-nwatters-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-07-14 8:34 ` Joerg Roedel [this message]
2016-07-14 10:36 ` Robin Murphy
[not found] ` <57876B45.6010206-5wv7dgnIgG8@public.gmane.org>
2016-07-14 11:21 ` Auger Eric
[not found] ` <77bca715-36e1-eb11-a49b-5d389b6cc0e8-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-07-14 17:55 ` nwatters-sgV2jX0FEOL9JmXXK+q4OQ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714083420.GR12639@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nwatters-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).