From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v5 08/19] iommu/arm-smmu: Handle stream IDs more dynamically Date: Thu, 1 Sep 2016 19:17:14 +0100 Message-ID: <20160901181713.GS6721@arm.com> References: <36f71a07fbc6037ca664bdcc540650f893081dd1.1471975357.git.robin.murphy@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <36f71a07fbc6037ca664bdcc540650f893081dd1.1471975357.git.robin.murphy-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, punit.agrawal-5wv7dgnIgG8@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Tue, Aug 23, 2016 at 08:05:19PM +0100, Robin Murphy wrote: > Rather than assuming fixed worst-case values for stream IDs and SMR > masks, keep track of whatever implemented bits the hardware actually > reports. This also obviates the slightly questionable validation of SMR > fields in isolation - rather than aborting the whole SMMU probe for a > hardware configuration which is still architecturally valid, we can > simply refuse masters later if they try to claim an unrepresentable ID > or mask (which almost certainly implies a DT error anyway). > > Signed-off-by: Robin Murphy > --- > drivers/iommu/arm-smmu.c | 43 ++++++++++++++++++++++--------------------- > 1 file changed, 22 insertions(+), 21 deletions(-) Looks good to me: Acked-by: Will Deacon Will