From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH v13 08/15] vfio: Introduce a vfio_dma type field Date: Thu, 6 Oct 2016 14:18:05 -0600 Message-ID: <20161006141805.1ba48859@t450s.home> References: <1475743531-4780-1-git-send-email-eric.auger@redhat.com> <1475743531-4780-9-git-send-email-eric.auger@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1475743531-4780-9-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Eric Auger Cc: yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, marc.zyngier-5wv7dgnIgG8@public.gmane.org, p.fedin-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, Manish.Jaggi-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org, christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Thu, 6 Oct 2016 08:45:24 +0000 Eric Auger wrote: > We introduce a vfio_dma type since we will need to discriminate > different types of dma slots: > - VFIO_IOVA_USER: IOVA region used to map user vaddr > - VFIO_IOVA_RESERVED_MSI: IOVA region reserved to map MSI doorbells > > Signed-off-by: Eric Auger Acked-by: Alex Williamson > > --- > v9 -> v10: > - renamed VFIO_IOVA_RESERVED into VFIO_IOVA_RESERVED_MSI > - explicitly set type to VFIO_IOVA_USER on dma_map > > v6 -> v7: > - add VFIO_IOVA_ANY > - do not introduce yet any VFIO_IOVA_RESERVED handling > --- > drivers/vfio/vfio_iommu_type1.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 2ba1942..a9f8b93 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -53,6 +53,12 @@ module_param_named(disable_hugepages, > MODULE_PARM_DESC(disable_hugepages, > "Disable VFIO IOMMU support for IOMMU hugepages."); > > +enum vfio_iova_type { > + VFIO_IOVA_USER = 0, /* standard IOVA used to map user vaddr */ > + VFIO_IOVA_RESERVED_MSI, /* reserved to map MSI doorbells */ > + VFIO_IOVA_ANY, /* matches any IOVA type */ > +}; > + > struct vfio_iommu { > struct list_head domain_list; > struct mutex lock; > @@ -75,6 +81,7 @@ struct vfio_dma { > unsigned long vaddr; /* Process virtual addr */ > size_t size; /* Map size (bytes) */ > int prot; /* IOMMU_READ/WRITE */ > + enum vfio_iova_type type; /* type of IOVA */ > }; > > struct vfio_group { > @@ -607,6 +614,7 @@ static int vfio_dma_do_map(struct vfio_iommu *iommu, > dma->iova = iova; > dma->vaddr = vaddr; > dma->prot = prot; > + dma->type = VFIO_IOVA_USER; > > /* Insert zero-sized and grow as we map chunks of it */ > vfio_link_dma(iommu, dma);