From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [GIT PULL] iommu/arm-smmu: Fixes for 4.9 Date: Thu, 3 Nov 2016 17:14:07 +0100 Message-ID: <20161103161407.GR3541@8bytes.org> References: <20161028160148.GD1076@arm.com> <20161103153303.GA837@8bytes.org> <20161103160006.GS22791@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161103160006.GS22791-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Will Deacon Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Thu, Nov 03, 2016 at 04:00:06PM +0000, Will Deacon wrote: > We're basically doing that already, since the bus_set_iommu call happens in > the probe routine, which won't run unless an SMMUv3 has been found in the > DT. The issue we're trying to avoid is failing the probe of a second SMMUv3 > in the system, because the bus will already have the iommu ops set by the > first SMMUv3 that probed. > > I suppose we could go and compare bus->iommu_ops with &arm_smmu_ops, but > given that we can't support different IOMMU types on a single bus, I don't > think we gain anything from that. Can you instead check whether there is already another smmu probed and skip the bus_set_iommu call then? Joerg