From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/5] iommu: Allow taking a reference on a group directly
Date: Thu, 10 Nov 2016 18:28:25 +0100 [thread overview]
Message-ID: <20161110172824.GM2078@8bytes.org> (raw)
In-Reply-To: <20161109180059.GJ17771-5wv7dgnIgG8@public.gmane.org>
On Wed, Nov 09, 2016 at 06:00:59PM +0000, Will Deacon wrote:
> I'd still rather the new function was renamed. We already have the group,
> so calling a weird underscore version of iommu_group_get is really
> counter-intuitive.
>
> Joerg -- do you have a preference?
iommu_group_ref_get sound best to me. Unfortunatly C has no function
overloading ;)
Joerg
prev parent reply other threads:[~2016-11-10 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 12:47 [PATCH 1/5] iommu: Allow taking a reference on a group directly Robin Murphy
[not found] ` <3922e1f14d8ecb50440b2d9b0d1123f3c9307fc5.1478695557.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-11-09 12:47 ` [PATCH 2/5] iommu/arm-smmu: Fix group refcounting Robin Murphy
2016-11-09 12:47 ` [PATCH 3/5] iommu/amd: " Robin Murphy
2016-11-09 12:47 ` [PATCH 4/5] iommu/mediatek: Fix M4Uv2 " Robin Murphy
2016-11-09 12:47 ` [PATCH 5/5] iommu/mediatek: Fix M4Uv1 " Robin Murphy
2016-11-09 14:10 ` [PATCH 1/5] iommu: Allow taking a reference on a group directly Sricharan
2016-11-09 17:25 ` Will Deacon
[not found] ` <20161109172543.GI17771-5wv7dgnIgG8@public.gmane.org>
2016-11-09 17:46 ` Robin Murphy
[not found] ` <8b35afe8-7e09-c2d3-91ae-5d2a10da6fc8-5wv7dgnIgG8@public.gmane.org>
2016-11-09 18:00 ` Will Deacon
[not found] ` <20161109180059.GJ17771-5wv7dgnIgG8@public.gmane.org>
2016-11-10 17:28 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110172824.GM2078@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).