From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 1/5] iommu: Allow taking a reference on a group directly Date: Thu, 10 Nov 2016 18:28:25 +0100 Message-ID: <20161110172824.GM2078@8bytes.org> References: <3922e1f14d8ecb50440b2d9b0d1123f3c9307fc5.1478695557.git.robin.murphy@arm.com> <20161109172543.GI17771@arm.com> <8b35afe8-7e09-c2d3-91ae-5d2a10da6fc8@arm.com> <20161109180059.GJ17771@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20161109180059.GJ17771-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Will Deacon Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Wed, Nov 09, 2016 at 06:00:59PM +0000, Will Deacon wrote: > I'd still rather the new function was renamed. We already have the group, > so calling a weird underscore version of iommu_group_get is really > counter-intuitive. > > Joerg -- do you have a preference? iommu_group_ref_get sound best to me. Unfortunatly C has no function overloading ;) Joerg