From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 09/10] iommu/exynos: Make use of iommu_device_register interface Date: Wed, 8 Feb 2017 14:57:42 +0100 Message-ID: <20170208135742.GE7339@8bytes.org> References: <1486397429-29327-1-git-send-email-joro@8bytes.org> <1486397429-29327-10-git-send-email-joro@8bytes.org> <3e4709a7-2231-7c76-18bd-6e2d6b802b8e@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <3e4709a7-2231-7c76-18bd-6e2d6b802b8e-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Marek Szyprowski Cc: David Woodhouse , Will Deacon , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joerg Roedel , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Marek, On Tue, Feb 07, 2017 at 01:36:15PM +0100, Marek Szyprowski wrote: > >+ ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, > >+ "sysmmu.%pa", &ioaddr); > > Can we stick to the common name across the /sysfs and use > dev_name(data->sysmmu) > or even dev_name(dev) here? > > ret = iommu_device_sysfs_add(&data->iommu, &pdev->dev, NULL, > dev_name(dev)); That means that we have multiple 'struct device' with the same name, no? I think will lead to confusion when using dev_printk, as its not clear anymore which device is refered to in the message. Joerg