From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v2] iommu: iova: Consolidate code for adding new node to iovad domain rbtree Date: Tue, 21 Mar 2017 14:59:29 +0100 Message-ID: <20170321135928.GA29659@8bytes.org> References: <1487934817-11725-1-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1487934817-11725-1-git-send-email-m.szyprowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Robin Murphy List-Id: iommu@lists.linux-foundation.org On Fri, Feb 24, 2017 at 12:13:37PM +0100, Marek Szyprowski wrote: > This patch consolidates almost the same code used in iova_insert_rbtree() > and __alloc_and_insert_iova_range() functions. While touching this code, > replace BUG() with WARN_ON(1) to avoid taking down the whole system in > case of corrupted iova tree or incorrect calls. > > Signed-off-by: Marek Szyprowski > --- > v2: > - replaced BUG() with WARN_ON(1) as suggested by Robin Murphy > > v1: > - initial version Applied, thanks.