From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu/vt-d: Make sure IOMMUs are off when intel_iommu=off Date: Wed, 29 Mar 2017 23:01:43 +0200 Message-ID: <20170329210143.GV8329@suse.de> References: <1490799639-15965-1-git-send-email-joro@8bytes.org> <20170329085153.5d215d44@jacob-builder> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170329085153.5d215d44@jacob-builder> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jacob Pan Cc: David Woodhouse , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Wed, Mar 29, 2017 at 08:51:53AM -0700, Jacob Pan wrote: > On Wed, 29 Mar 2017 17:00:39 +0200 > Joerg Roedel wrote: > > +static void intel_disable_iommus(void) > > +{ > > + struct intel_iommu *iommu = NULL; > > + struct dmar_drhd_unit *drhd; > > + > > + for_each_iommu(iommu, drhd) > > + iommu_disable_translation(iommu); > should we also disable IR here? i.e. > iommu_disable_irq_remapping(iommu); No, irq remapping depends on another parameter (intremap=off) and needs to be handled seperatly. I already looked at it and this needs to be part of a larger effort as it required changes in code-paths that are shared between Intel and AMD IOMMU drivers. Joerg