From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH] iommu/arm-smmu-v3: Increase SMMU CMD queue poll timeout Date: Mon, 24 Apr 2017 17:08:41 +0100 Message-ID: <20170424160841.GS12323@arm.com> References: <1493035176-3633-1-git-send-email-gakula@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1493035176-3633-1-git-send-email-gakula-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Geetha sowjanya Cc: Sunil.Goutham-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Geetha , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, Apr 24, 2017 at 05:29:36PM +0530, Geetha sowjanya wrote: > From: Geetha > > When large memory is being unmapped, huge no of tlb invalidation cmds are > submitted followed by a SYNC command. This sometimes hits CMD queue full and > poll on queue drain is being timedout throwing error message 'CMD_SYNC timeout'. > > Although there is no functional issue, error message confuses user. Hence increased > poll timeout to 500us Hmm, what are you doing to unmap that much? Is this VFIO teardown? Do you have 7c6d90e2bb1a ("iommu/io-pgtable-arm: Fix iova_to_phys for block entries") applied? Will > > Signed-off-by: Geetha > --- > drivers/iommu/arm-smmu-v3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 591bb96..1dcd154 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -407,7 +407,7 @@ > #define PRIQ_1_ADDR_MASK 0xfffffffffffffUL > > /* High-level queue structures */ > -#define ARM_SMMU_POLL_TIMEOUT_US 100 > +#define ARM_SMMU_POLL_TIMEOUT_US 500 > > #define MSI_IOVA_BASE 0x8000000 > #define MSI_IOVA_LENGTH 0x100000 > -- > 1.9.1 >