From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu: Print a message with the default domain type created Date: Wed, 26 Apr 2017 17:50:44 +0200 Message-ID: <20170426155044.GA1332@8bytes.org> References: <20170426143813.21225-1-rrichter@cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170426143813.21225-1-rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robert Richter Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Robert, On Wed, Apr 26, 2017 at 04:38:13PM +0200, Robert Richter wrote: > - pr_info("Adding device %s to group %d\n", dev_name(dev), group->id); > + pr_info("Adding device %s to group %d, default domain type %d\n", > + dev_name(dev), group->id, > + group->default_domain ? group->default_domain->type : -1); Printing just a number is not very user-friendly. We have only two default domain-types right now, so it is sufficient to just print additional information if a device is identity-mapped. Something like "Adding device %s to group %d - using identity mapping" Regards, Joerg