From: Joerg Roedel <joro@8bytes.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mark Rutland <mark.rutland@arm.com>,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org
Subject: Re: [patch 10/18] iommu/vt-d: Adjust system_state checks
Date: Mon, 15 May 2017 16:42:39 +0200 [thread overview]
Message-ID: <20170515144239.GD14127@8bytes.org> (raw)
In-Reply-To: <20170514183613.238367369@linutronix.de>
On Sun, May 14, 2017 at 08:27:26PM +0200, Thomas Gleixner wrote:
> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
>
> Adjust the system_state checks in dmar_parse_one_atsr() and
> dmar_iommu_notify_scope_dev() to handle the extra states.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: iommu@lists.linux-foundation.org
> ---
> drivers/iommu/intel-iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Joerg Roedel <jroedel@suse.de>
>
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -4312,7 +4312,7 @@ int dmar_parse_one_atsr(struct acpi_dmar
> struct acpi_dmar_atsr *atsr;
> struct dmar_atsr_unit *atsru;
>
> - if (system_state != SYSTEM_BOOTING && !intel_iommu_enabled)
> + if (system_state >= SYSTEM_RUNNING && !intel_iommu_enabled)
> return 0;
>
> atsr = container_of(hdr, struct acpi_dmar_atsr, header);
> @@ -4562,7 +4562,7 @@ int dmar_iommu_notify_scope_dev(struct d
> struct acpi_dmar_atsr *atsr;
> struct acpi_dmar_reserved_memory *rmrr;
>
> - if (!intel_iommu_enabled && system_state != SYSTEM_BOOTING)
> + if (!intel_iommu_enabled && system_state >= SYSTEM_RUNNING)
> return 0;
>
> list_for_each_entry(rmrru, &dmar_rmrr_units, list) {
>
next prev parent reply other threads:[~2017-05-15 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170514182716.347236777@linutronix.de>
2017-05-14 18:27 ` [patch 10/18] iommu/vt-d: Adjust system_state checks Thomas Gleixner
2017-05-15 14:42 ` Joerg Roedel [this message]
2017-05-14 18:27 ` [patch 11/18] iommu/of: Adjust system_state check Thomas Gleixner
[not found] ` <20170514183613.331455858-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2017-05-15 10:45 ` Robin Murphy
2017-05-15 14:42 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515144239.GD14127@8bytes.org \
--to=joro@8bytes.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).