From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h Date: Wed, 17 May 2017 14:51:45 +0200 Message-ID: <20170517125144.GD11068@8bytes.org> References: <20170511113619.2596882-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170511113619.2596882-1-arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Arnd Bergmann Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Thu, May 11, 2017 at 01:35:51PM +0200, Arnd Bergmann wrote: > The mediatek iommu driver relied on an implicit include of dma-mapping.h, > but for some reason that is no longer there in 4.12-rc1: > > drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise': > drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration] > drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free': > drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration] > > This adds an explicit #include to make it build again. > > Signed-off-by: Arnd Bergmann Applied to iommu/fixes, thanks Arnd. This was probably another victim of 208480b iommu: Remove trace-events include from iommu.h