From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 03/44] dmaengine: ioat: don't use DMA_ERROR_CODE Date: Sun, 18 Jun 2017 00:09:25 -0700 Message-ID: <20170618070925.GA18526@infradead.org> References: <20170616181059.19206-1-hch@lst.de> <20170616181059.19206-4-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-ia64-owner@vger.kernel.org To: Alexander Duyck Cc: Christoph Hellwig , the arch/x86 maintainers , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, openrisc@lists.librecores.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, "open list:INTEL IOMMU (VT-d)" , Netdev , "linux-kernel@vger.kernel.org" List-Id: iommu@lists.linux-foundation.org On Fri, Jun 16, 2017 at 01:40:24PM -0700, Alexander Duyck wrote: > dma_unmap_page on dest_dma if "op == IOAT_OP_XOR"? Odds are it is what > the compiler is already generating and will save a few lines of code > so what you end up with is something like: Honestly wanted to touch the code as little as possible :) If we want to make it prettier and more readable it needs to be refactored. If you're interested I can take a stab at that, but I'd like to keep it out of this already giant series.