From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerald Schaefer Subject: Re: [PATCH 1/3] iommu: Return ERR_PTR() values from device_group call-backs Date: Wed, 28 Jun 2017 17:48:08 +0200 Message-ID: <20170628174808.09a85fc6@thinkpad> References: <1498651258-23700-1-git-send-email-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1498651258-23700-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joerg Roedel List-Id: iommu@lists.linux-foundation.org On Wed, 28 Jun 2017 14:00:56 +0200 Joerg Roedel wrote: > From: Joerg Roedel > > The generic device_group call-backs in iommu.c return NULL > in case of error. Since they are getting ERR_PTR values from > iommu_group_alloc(), just pass them up instead. > > Reported-by: Gerald Schaefer > Signed-off-by: Joerg Roedel > --- Looks good, Reviewed-by: Gerald Schaefer > drivers/iommu/iommu.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index cf7ca7e..de09e1e 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -915,13 +915,7 @@ static int get_pci_alias_or_group(struct pci_dev *pdev, u16 alias, void *opaque) > */ > struct iommu_group *generic_device_group(struct device *dev) > { > - struct iommu_group *group; > - > - group = iommu_group_alloc(); > - if (IS_ERR(group)) > - return NULL; > - > - return group; > + return iommu_group_alloc(); > } > > /* > @@ -988,11 +982,7 @@ struct iommu_group *pci_device_group(struct device *dev) > return group; > > /* No shared group found, allocate new */ > - group = iommu_group_alloc(); > - if (IS_ERR(group)) > - return NULL; > - > - return group; > + return iommu_group_alloc(); > } > > /**