From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Date: Thu, 27 Jul 2017 17:57:55 +0200 Message-ID: <20170727155755.GP3610@suse.de> References: <1500627551-12930-1-git-send-email-bhe@redhat.com> <1500627551-12930-12-git-send-email-bhe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1500627551-12930-12-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Baoquan He Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Fri, Jul 21, 2017 at 04:59:09PM +0800, Baoquan He wrote: > When iommu is pre_enabled in kdump kernel, if a device is set up with > guest translations (DTE.GV=1), then don't copy GCR3 table root pointer > but move the device over to an empty guest-cr3 table and handle the > faults in the PPR log (which answer them with INVALID). After all these > PPR faults are recoverable for the device and we should not allow the > device to change old-kernels data when we don't have to. Okay, forget my previous comment about disabling IOMMUv2 features while copying. Its done in this patch.