From: Joerg Roedel <jroedel@suse.de>
To: Baoquan He <bhe@redhat.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 12/13] iommu/amd: Clear out the GV flag when handle deferred domain attach
Date: Fri, 4 Aug 2017 14:30:41 +0200 [thread overview]
Message-ID: <20170804123041.GX3431@suse.de> (raw)
In-Reply-To: <1501587449-9817-13-git-send-email-bhe@redhat.com>
On Tue, Aug 01, 2017 at 07:37:28PM +0800, Baoquan He wrote:
> @@ -2466,11 +2472,21 @@ static struct protection_domain *get_domain(struct device *dev)
> return ERR_PTR(-EINVAL);
>
> domain = get_dev_data(dev)->domain;
> - if (domain == NULL && get_dev_data(dev)->defer_attach) {
> + if (domain == NULL && dev_data->defer_attach) {
> + u16 alias = amd_iommu_alias_table[dev_data->devid];
> get_dev_data(dev)->defer_attach = false;
> io_domain = iommu_get_domain_for_dev(dev);
> domain = to_pdomain(io_domain);
> attach_device(dev, domain);
> + /*
> + * If the deferred attached domain is not v2, should clear out
> + * the old GV flag.
> + */
> + if (!(domain->flags & PD_IOMMUV2_MASK)) {
> + clear_dte_flag_gv(dev_data->devid);
> + if (alias != dev_data->devid)
> + clear_dte_flag_gv(dev_data->devid);
Hmm, thinking more about it, I am not sure what the IOMMU responds to
PRI/PASID prefixes if the GV flag is 0.
But until we know it causes problems we should just disable the bit
while doing the copy in the previous patch and avoid any special
handling like done here.
next prev parent reply other threads:[~2017-08-04 12:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 11:37 [PATCH v9 00/13] Fix the on-flight DMA issue on system with amd iommu Baoquan He
2017-08-01 11:37 ` [PATCH v9 01/13] iommu/amd: Detect pre enabled translation Baoquan He
2017-08-01 11:37 ` [PATCH v9 02/13] iommu/amd: add several helper functions Baoquan He
2017-08-01 11:37 ` [PATCH v9 03/13] Revert "iommu/amd: Suppress IO_PAGE_FAULTs in kdump kernel" Baoquan He
2017-08-01 11:37 ` [PATCH v9 04/13] iommu/amd: Define bit fields for DTE particularly Baoquan He
2017-08-01 11:37 ` [PATCH v9 06/13] iommu/amd: copy old trans table from old kernel Baoquan He
2017-08-04 12:21 ` Joerg Roedel
2017-08-04 13:09 ` Baoquan He
2017-08-01 11:37 ` [PATCH v9 07/13] iommu/amd: Do sanity check for address translation and irq remap of old dev table entry Baoquan He
[not found] ` <1501587449-9817-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-01 11:37 ` [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He
2017-08-04 12:09 ` Joerg Roedel
2017-08-04 12:21 ` Baoquan He
2017-08-04 12:30 ` Baoquan He
2017-08-04 12:51 ` Joerg Roedel
[not found] ` <20170804125159.GY3431-l3A5Bk7waGM@public.gmane.org>
2017-08-04 13:00 ` Baoquan He
2017-08-01 11:37 ` [PATCH v9 08/13] iommu: Add is_attach_deferred call-back to iommu-ops Baoquan He
2017-08-01 11:37 ` [PATCH v9 09/13] iommu/amd: Use is_attach_deferred call-back Baoquan He
2017-08-01 11:37 ` [PATCH v9 10/13] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled Baoquan He
2017-08-04 12:25 ` Joerg Roedel
[not found] ` <20170804122524.GV3431-l3A5Bk7waGM@public.gmane.org>
2017-08-04 13:01 ` Baoquan He
2017-08-01 11:37 ` [PATCH v9 11/13] iommu/amd: Don't copy GCR3 table root pointer Baoquan He
2017-08-04 12:27 ` Joerg Roedel
2017-08-01 11:37 ` [PATCH v9 12/13] iommu/amd: Clear out the GV flag when handle deferred domain attach Baoquan He
2017-08-04 12:30 ` Joerg Roedel [this message]
2017-08-04 13:13 ` Baoquan He
2017-08-04 13:18 ` Joerg Roedel
2017-08-01 11:37 ` [PATCH v9 13/13] iommu/amd: Disable iommu only if amd_iommu=off is specified Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804123041.GX3431@suse.de \
--to=jroedel@suse.de \
--cc=bhe@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).