From: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables()
Date: Fri, 4 Aug 2017 21:00:46 +0800 [thread overview]
Message-ID: <20170804130046.GL1874@x1> (raw)
In-Reply-To: <20170804125159.GY3431-l3A5Bk7waGM@public.gmane.org>
On 08/04/17 at 02:51pm, Joerg Roedel wrote:
> On Fri, Aug 04, 2017 at 08:30:39PM +0800, Baoquan He wrote:
> > Sorry, I don't get 'this one' meaning, are you suggesting the copy for
> > loop should be take out of the iommu for loop?
> >
> > About the temporary copy of the old device-table, you can see in patch
> > 7/13, if irq sanity check failed, it return -1. This return could happen
> > in the middle of copy. So I think we should do a whole successful copy,
> > or don't copy at all. It might not be good do half copy.
>
> No, I mean that you should move the copy of the complete device-table
> out of the for_each_iommu() loop. Currently you make sure you copy only
> once with the 'copied' flag, but that is not necessary if you move the
> code behind the loop.
Ok, will do. Thanks!
>
next prev parent reply other threads:[~2017-08-04 13:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 11:37 [PATCH v9 00/13] Fix the on-flight DMA issue on system with amd iommu Baoquan He
2017-08-01 11:37 ` [PATCH v9 01/13] iommu/amd: Detect pre enabled translation Baoquan He
2017-08-01 11:37 ` [PATCH v9 02/13] iommu/amd: add several helper functions Baoquan He
2017-08-01 11:37 ` [PATCH v9 03/13] Revert "iommu/amd: Suppress IO_PAGE_FAULTs in kdump kernel" Baoquan He
2017-08-01 11:37 ` [PATCH v9 04/13] iommu/amd: Define bit fields for DTE particularly Baoquan He
[not found] ` <1501587449-9817-1-git-send-email-bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-01 11:37 ` [PATCH v9 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He
2017-08-04 12:09 ` Joerg Roedel
2017-08-04 12:21 ` Baoquan He
2017-08-04 12:30 ` Baoquan He
2017-08-04 12:51 ` Joerg Roedel
[not found] ` <20170804125159.GY3431-l3A5Bk7waGM@public.gmane.org>
2017-08-04 13:00 ` Baoquan He [this message]
2017-08-01 11:37 ` [PATCH v9 08/13] iommu: Add is_attach_deferred call-back to iommu-ops Baoquan He
2017-08-01 11:37 ` [PATCH v9 06/13] iommu/amd: copy old trans table from old kernel Baoquan He
2017-08-04 12:21 ` Joerg Roedel
2017-08-04 13:09 ` Baoquan He
2017-08-01 11:37 ` [PATCH v9 07/13] iommu/amd: Do sanity check for address translation and irq remap of old dev table entry Baoquan He
2017-08-01 11:37 ` [PATCH v9 09/13] iommu/amd: Use is_attach_deferred call-back Baoquan He
2017-08-01 11:37 ` [PATCH v9 10/13] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled Baoquan He
2017-08-04 12:25 ` Joerg Roedel
[not found] ` <20170804122524.GV3431-l3A5Bk7waGM@public.gmane.org>
2017-08-04 13:01 ` Baoquan He
2017-08-01 11:37 ` [PATCH v9 11/13] iommu/amd: Don't copy GCR3 table root pointer Baoquan He
2017-08-04 12:27 ` Joerg Roedel
2017-08-01 11:37 ` [PATCH v9 12/13] iommu/amd: Clear out the GV flag when handle deferred domain attach Baoquan He
2017-08-04 12:30 ` Joerg Roedel
2017-08-04 13:13 ` Baoquan He
2017-08-04 13:18 ` Joerg Roedel
2017-08-01 11:37 ` [PATCH v9 13/13] iommu/amd: Disable iommu only if amd_iommu=off is specified Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804130046.GL1874@x1 \
--to=bhe-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).