From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baoquan He Subject: Re: [PATCH 1/2] iommu/amd: Fix compiler warning in copy_device_table() Date: Sat, 19 Aug 2017 09:16:00 +0800 Message-ID: <20170819011600.GC20615@x1> References: <1503096026-6851-1-git-send-email-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1503096026-6851-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Joerg Roedel , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 08/19/17 at 12:40am, Joerg Roedel wrote: > From: Joerg Roedel > > This was reported by the kbuild bot. The condition in which > entry would be used uninitialized can not happen, because > when there is no iommu this function would never be called. > But its no fast-path, so fix the warning anyway. > > Reported-by: kbuild test robot > Signed-off-by: Joerg Roedel Thanks for fixing these code bugs, Joerg. Ack the series! Acked-by: Baoquan He > --- > drivers/iommu/amd_iommu_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c > index c7d0325..f2023cd 100644 > --- a/drivers/iommu/amd_iommu_init.c > +++ b/drivers/iommu/amd_iommu_init.c > @@ -854,7 +854,7 @@ static int get_dev_entry_bit(u16 devid, u8 bit) > > static bool copy_device_table(void) > { > - u64 int_ctl, int_tab_len, entry, last_entry = 0; > + u64 int_ctl, int_tab_len, entry = 0, last_entry = 0; > struct dev_table_entry *old_devtb = NULL; > u32 lo, hi, devid, old_devtb_size; > phys_addr_t old_devtb_phys; > -- > 2.7.4 >