From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
Cc: Magnus Damm
<damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] iommu/io-pgtable-arm: Convert to IOMMU API TLB sync
Date: Wed, 27 Sep 2017 14:27:26 +0200 [thread overview]
Message-ID: <20170927122726.GM8398@8bytes.org> (raw)
In-Reply-To: <20170922154322.GA27080-5wv7dgnIgG8@public.gmane.org>
Hi Will, Robin,
On Fri, Sep 22, 2017 at 04:43:22PM +0100, Will Deacon wrote:
> Joerg, do you reckon it's worth merging this as-is, or should we also
> hook up add_flush before implementing this?
The patches implement .iotlb_sync() so that it is okay to not have a
.iotlb_range_add() call-back for now. But the patches lack a
.flush_iotlb_range() call-back, which is strictly necessary for
correctness because it is defined to be synchronous and doesn't require
a sync-call afterwards.
Regards,
Joerg
next prev parent reply other threads:[~2017-09-27 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 15:21 [PATCH 1/2] iommu/io-pgtable-arm: Convert to IOMMU API TLB sync Robin Murphy
[not found] ` <a472d061559a6afcc4631e881e9420944471f461.1505747866.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2017-09-18 15:21 ` [PATCH 2/2] iommu/io-pgtable-arm-v7s: " Robin Murphy
2017-09-22 15:43 ` [PATCH 1/2] iommu/io-pgtable-arm: " Will Deacon
[not found] ` <20170922154322.GA27080-5wv7dgnIgG8@public.gmane.org>
2017-09-27 12:27 ` Joerg Roedel [this message]
[not found] ` <20170927122726.GM8398-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-09-27 12:34 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927122726.GM8398@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox