From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: refactor dma_cache_sync V2 Date: Tue, 3 Oct 2017 12:43:00 +0200 Message-ID: <20171003104311.10058-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Cc: Chris Zankel , Michal Simek , linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Howells , Max Filippov , Guan Xuetao List-Id: iommu@lists.linux-foundation.org The dma_cache_sync routines is used to flush caches for memory returned by dma_alloc_attrs with the DMA_ATTR_NON_CONSISTENT flag (or previously from dma_alloc_noncoherent), but the requirements for it seems to be frequently misunderstood. dma_cache_sync is documented to be a no-op for allocations that do not have the DMA_ATTR_NON_CONSISTENT flag set, and yet a lot of architectures implement it in some way despite not implementing DMA_ATTR_NON_CONSISTENT. This series removes a few abuses of dma_cache_sync for non-DMA API purposes, then changes all remaining architectures that do not implement DMA_ATTR_NON_CONSISTENT to implement dma_cache_sync as a no-op, and then adds the struct dma_map_ops indirection we use for all other DMA mapping operations to dma_cache_sync as well, thus removing all but two implementations of the function. Changes since V1: - drop the mips fd_cacheflush, merged via maintainer - spelling fix in last commit descriptions (thanks Geert)