[PATCH] iommu/amd: remove unused variable flush_addr

[PATCH] iommu/amd: remove unused variable flush_addr

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

Variable flush_addr is being assigned but is never read; it
is redundant and can be removed. Cleans up the clang warning:

drivers/iommu/amd_iommu.c:2388:2: warning: Value stored to 'flush_addr'
is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/iommu/amd_iommu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 5a72f40d6532..a99d41fc3a1d 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -2382,11 +2382,9 @@ static void __unmap_single(struct dma_ops_domain *dma_dom,
 			   size_t size,
 			   int dir)
 {
-	dma_addr_t flush_addr;
 	dma_addr_t i, start;
 	unsigned int pages;
 
-	flush_addr = dma_addr;
 	pages = iommu_num_pages(dma_addr, size, PAGE_SIZE);
 	dma_addr &= PAGE_MASK;
 	start = dma_addr;
-- 
2.14.1

Re: [PATCH] iommu/amd: remove unused variable flush_addr

[Alex Williamson]

On Sun, 22 Oct 2017 13:49:45 +0200
Colin King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> wrote:

> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> 
> Variable flush_addr is being assigned but is never read; it
> is redundant and can be removed. Cleans up the clang warning:
> 
> drivers/iommu/amd_iommu.c:2388:2: warning: Value stored to 'flush_addr'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
>  drivers/iommu/amd_iommu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index 5a72f40d6532..a99d41fc3a1d 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -2382,11 +2382,9 @@ static void __unmap_single(struct dma_ops_domain *dma_dom,
>  			   size_t size,
>  			   int dir)
>  {
> -	dma_addr_t flush_addr;
>  	dma_addr_t i, start;
>  	unsigned int pages;
>  
> -	flush_addr = dma_addr;
>  	pages = iommu_num_pages(dma_addr, size, PAGE_SIZE);
>  	dma_addr &= PAGE_MASK;
>  	start = dma_addr;

Applied to iommu/updates for v4.15, thanks,

Alex