From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Konrad Rzeszutek Wilk <konrad@darnok.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH 1/2] mmc: renesas_sdhi: fix swiotlb buffer is full
Date: Fri, 3 Nov 2017 09:23:22 -0400 [thread overview]
Message-ID: <20171103132322.GA19352@x230.dumpdata.com> (raw)
In-Reply-To: <TY1PR06MB0992CBE1B122C62BD5E1C227D85C0@TY1PR06MB0992.apcprd06.prod.outlook.com>
..snip..
> > >
> > > Anyway, I made v2 patches by using swiotlb related definitions. Would you check it?
> >
> > Did I miss that email? As in was I cc-ed?
>
> This was my fault. When I submitted v2 patches, I didn't include your email and iommu mailing list...
No problem.
>
> > > https://patchwork.kernel.org/patch/10018879/
> >
> > Why not use IO_TLB_SEGSIZE << IO_TLB_SHIFT or alternatively
> > swiotlb_max_segment? See 5584f1b1d73e9
>
> I already made such a patch as v2 and it was merged into mmc.git / fixes branch.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?h=fixes&id=e90e8da72ad694a16a4ffa6e5adae3610208f73b
What happens if the user has swiotlb=4096 on the command line (meaning
less than the default value)? Your max value will be incorrect. Could you use
swiotlb_max_segment?
next prev parent reply other threads:[~2017-11-03 13:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1508225421-25405-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
[not found] ` <1508225421-25405-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>
[not found] ` <1508225421-25405-2-git-send-email-yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-10-17 8:02 ` [PATCH 1/2] mmc: renesas_sdhi: fix swiotlb buffer is full Geert Uytterhoeven
[not found] ` <CAMuHMdXyY-gvQGn2UxhUDsdhdWUMmTA80z73PF14otvcKuTMaw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-19 0:24 ` Konrad Rzeszutek Wilk
[not found] ` <20171019002412.GA14493-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-10-19 8:34 ` Geert Uytterhoeven
2017-10-19 11:39 ` Yoshihiro Shimoda
2017-10-20 3:18 ` Yoshihiro Shimoda
2017-11-01 13:26 ` Konrad Rzeszutek Wilk
[not found] ` <20171101132639.GA24821-sHAKZZqAc8NKMcnDSFYBzAC/G2K4zDHf@public.gmane.org>
2017-11-02 4:10 ` Yoshihiro Shimoda
2017-11-03 13:23 ` Konrad Rzeszutek Wilk [this message]
[not found] ` <20171103132322.GA19352-sHAKZZqAc8NKMcnDSFYBzAC/G2K4zDHf@public.gmane.org>
2017-11-03 14:01 ` Geert Uytterhoeven
[not found] ` <CAMuHMdWxWu-6Hi+4P2GhEyjfu=mhbNUUOoBUC7JrsL=ki35c5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-03 14:17 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103132322.GA19352@x230.dumpdata.com \
--to=konrad@kernel.org \
--cc=geert@linux-m68k.org \
--cc=iommu@lists.linux-foundation.org \
--cc=konrad@darnok.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).