From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 1/2] mmc: renesas_sdhi: fix swiotlb buffer is full Date: Fri, 3 Nov 2017 09:23:22 -0400 Message-ID: <20171103132322.GA19352@x230.dumpdata.com> References: <1508225421-25405-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1508225421-25405-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> <20171019002412.GA14493@localhost.localdomain> <20171101132639.GA24821@x230.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Yoshihiro Shimoda Cc: Geert Uytterhoeven , Konrad Rzeszutek Wilk , Linux-Renesas , Wolfram Sang , Ulf Hansson , Linux MMC List , "iommu@lists.linux-foundation.org" List-Id: iommu@lists.linux-foundation.org ..snip.. > > > > > > Anyway, I made v2 patches by using swiotlb related definitions. Would you check it? > > > > Did I miss that email? As in was I cc-ed? > > This was my fault. When I submitted v2 patches, I didn't include your email and iommu mailing list... No problem. > > > > https://patchwork.kernel.org/patch/10018879/ > > > > Why not use IO_TLB_SEGSIZE << IO_TLB_SHIFT or alternatively > > swiotlb_max_segment? See 5584f1b1d73e9 > > I already made such a patch as v2 and it was merged into mmc.git / fixes branch. > > https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/commit/?h=fixes&id=e90e8da72ad694a16a4ffa6e5adae3610208f73b What happens if the user has swiotlb=4096 on the command line (meaning less than the default value)? Your max value will be incorrect. Could you use swiotlb_max_segment?