From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH] iommu: Check the result of iommu_group_get() for NULL Date: Wed, 20 Dec 2017 12:02:31 -0700 Message-ID: <20171220120231.6c6f15e3@t450s.home> References: <1512408130-24833-1-git-send-email-jcrouse@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1512408130-24833-1-git-send-email-jcrouse-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Jordan Crouse Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, 4 Dec 2017 10:22:10 -0700 Jordan Crouse wrote: > The result of iommu_group_get() was being blindly used in both > attach and detach which results in a dereference when trying > to work with an unknown device. > > Signed-off-by: Jordan Crouse > --- > drivers/iommu/iommu.c | 5 +++++ > 1 file changed, 5 insertions(+) Applied to v4.16-iommu/misc. Thanks, Alex