* [PATCH] iommu/amd - Record more information about unknown events
@ 2017-12-04 19:52 Gary R Hook
[not found] ` <151241716233.31107.11094386543203626385.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Gary R Hook @ 2017-12-04 19:52 UTC (permalink / raw)
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA
When an unknown type event occurs, the default information written to
the syslog should dump raw event data. This could provide insight into
the event that occurred.
Signed-off-by: Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org>
---
drivers/iommu/amd_iommu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 51f8215877f5..cb78933ef53f 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -617,7 +617,9 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt)
address, flags);
break;
default:
- printk(KERN_ERR "UNKNOWN type=0x%02x]\n", type);
+ printk(KERN_ERR "UNKNOWN type=0x%02x event[0]=0x%08x "
+ "event[1]=0x%08x event[2]=0x%08x event[3]=0x%08x\n",
+ type, event[0], event[1], event[2], event[3]);
}
memset(__evt, 0, 4 * sizeof(u32));
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu/amd - Record more information about unknown events
[not found] ` <151241716233.31107.11094386543203626385.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
@ 2017-12-20 19:02 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2017-12-20 19:02 UTC (permalink / raw)
To: Gary R Hook
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Mon, 04 Dec 2017 13:52:42 -0600
Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org> wrote:
> When an unknown type event occurs, the default information written to
> the syslog should dump raw event data. This could provide insight into
> the event that occurred.
>
> Signed-off-by: Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org>
> ---
> drivers/iommu/amd_iommu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to v4.16-iommu/amd. Thanks,
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-20 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-04 19:52 [PATCH] iommu/amd - Record more information about unknown events Gary R Hook
[not found] ` <151241716233.31107.11094386543203626385.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org>
2017-12-20 19:02 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).