From: Jeffy Chen <jeffy.chen@rock-chips.com>
To: linux-kernel@vger.kernel.org
Cc: jcliang@chromium.org, tfiga@chromium.org,
Jeffy Chen <jeffy.chen@rock-chips.com>,
iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>
Subject: [PATCH] iommu/of: Only do IOMMU lookup for available ones
Date: Wed, 3 Jan 2018 14:09:20 +0800 [thread overview]
Message-ID: <20180103060920.23475-1-jeffy.chen@rock-chips.com> (raw)
The for_each_matching_node_and_match() would return every matching
nodes including unavailable ones.
It's pointless to init unavailable IOMMUs, so add a sanity check to
avoid that.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/iommu/of_iommu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 50947ebb6d17..6f7456caa30d 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -240,6 +240,9 @@ static int __init of_iommu_init(void)
for_each_matching_node_and_match(np, matches, &match) {
const of_iommu_init_fn init_fn = match->data;
+ if (!of_device_is_available(np))
+ continue;
+
if (init_fn && init_fn(np))
pr_err("Failed to initialise IOMMU %pOF\n", np);
}
--
2.11.0
next reply other threads:[~2018-01-03 6:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 6:09 Jeffy Chen [this message]
[not found] ` <20180103060920.23475-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-08 11:45 ` [PATCH] iommu/of: Only do IOMMU lookup for available ones Robin Murphy
2018-01-17 13:28 ` Joerg Roedel
[not found] ` <20180117132808.s5henw63oseg3ufd-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-01-18 14:41 ` Will Deacon
[not found] ` <20180118144118.GA12394-5wv7dgnIgG8@public.gmane.org>
2018-01-18 14:58 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103060920.23475-1-jeffy.chen@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jcliang@chromium.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox