From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v2 2/3] iommu/ipmmu-vmsa: Remove redundant of_iommu_init_fn hook Date: Wed, 17 Jan 2018 14:41:46 +0100 Message-ID: <20180117134146.fcf2dammcuoowiks@8bytes.org> References: <12163854e04da92b5de586912bf7257fc0fed79a.1515512134.git.robin.murphy@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <12163854e04da92b5de586912bf7257fc0fed79a.1515512134.git.robin.murphy-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, damm+renesas-yzvPICuk2ACczHhG9Qg4qA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Tue, Jan 09, 2018 at 04:17:26PM +0000, Robin Murphy wrote: > Having of_iommu_init() call ipmmu_init() via ipmmu_vmsa_iommu_of_setup() > does nothing that the subsys_initcall wouldn't do slightly later anyway, > since probe-deferral of masters means it is no longer critical to > register the driver super-early. Clean it up. > > Signed-off-by: Robin Murphy > --- Applied this one, thanks. The other two are already applied now from your first post.