Linux IOMMU Development
 help / color / mirror / Atom feed
From: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Subject: [PATCH v3 10/12] iommu/rockchip: Fix error handling in init
Date: Wed, 17 Jan 2018 23:25:40 +0800	[thread overview]
Message-ID: <20180117152542.26429-11-jeffy.chen@rock-chips.com> (raw)
In-Reply-To: <20180117152542.26429-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

It's hard to undo bus_set_iommu() in the error path, so move it to the
end of rk_iommu_probe().

Signed-off-by: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Reviewed-by: Tomasz Figa <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---

Changes in v3: None
Changes in v2:
Move bus_set_iommu() to rk_iommu_probe().

 drivers/iommu/rockchip-iommu.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index b1f177ae03c7..2c095f96c033 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -1195,6 +1195,8 @@ static int rk_iommu_probe(struct platform_device *pdev)
 	if (!dma_dev)
 		dma_dev = &pdev->dev;
 
+	bus_set_iommu(&platform_bus_type, &rk_iommu_ops);
+
 	return 0;
 err_remove_sysfs:
 	iommu_device_sysfs_remove(&iommu->iommu);
@@ -1220,19 +1222,6 @@ static struct platform_driver rk_iommu_driver = {
 
 static int __init rk_iommu_init(void)
 {
-	struct device_node *np;
-	int ret;
-
-	np = of_find_matching_node(NULL, rk_iommu_dt_ids);
-	if (!np)
-		return 0;
-
-	of_node_put(np);
-
-	ret = bus_set_iommu(&platform_bus_type, &rk_iommu_ops);
-	if (ret)
-		return ret;
-
 	return platform_driver_register(&rk_iommu_driver);
 }
 subsys_initcall(rk_iommu_init);
-- 
2.11.0

  parent reply	other threads:[~2018-01-17 15:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 15:25 [PATCH v3 00/12] iommu/rockchip: Use OF_IOMMU Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 04/12] iommu/rockchip: Fix error handling in attach Jeffy Chen
2018-01-17 15:25 ` [PATCH v3 06/12] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen
     [not found] ` <20180117152542.26429-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-17 15:25   ` [PATCH v3 01/12] iommu/rockchip: Prohibiat unbind and remove Jeffy Chen
2018-01-18  4:17     ` Tomasz Figa
     [not found]       ` <CAAFQd5B24j6OSStpYWiO-xfhH131mwNRk3=cEBakMpvsEkQ7wg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-18  8:28         ` JeffyChen
2018-01-17 15:25   ` [PATCH v3 02/12] iommu/rockchip: Fix error handling in probe Jeffy Chen
2018-01-17 15:25   ` [PATCH v3 03/12] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen
2018-01-17 15:25   ` [PATCH v3 05/12] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-01-17 15:25   ` [PATCH v3 07/12] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen
2018-01-17 15:25   ` [PATCH v3 08/12] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
2018-01-17 15:25   ` [PATCH v3 09/12] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-01-17 15:25   ` Jeffy Chen [this message]
2018-01-17 15:25   ` [PATCH v3 11/12] iommu/rockchip: Add runtime PM support Jeffy Chen
2018-01-17 15:25   ` [PATCH v3 12/12] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180117152542.26429-11-jeffy.chen@rock-chips.com \
    --to=jeffy.chen-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox