From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message Date: Wed, 17 Jan 2018 20:23:01 +0100 Message-ID: <20180117192301.GV28161@8bytes.org> References: <1516214399-24012-1-git-send-email-nwatters@codeaurora.org> <2f651cfe-e006-cf1d-b624-08e2ba5340fc@arm.com> <66706458-d971-be9b-4390-80a9be39248c@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <66706458-d971-be9b-4390-80a9be39248c-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Marc Zyngier Cc: Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sinan Kaya , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote: > On 17/01/18 18:54, Robin Murphy wrote: > Indeed. How about checking dev->msi_domain first, which should tell you > whether it is even possible to allocate MSIs, and fallback to wired IRQs > instead. That way, we keep the warning on genuine failures to allocate > MSIs, and you get to add a nice "Falling back to wired interrupts" > message when msi_domain is NULL. > > Thoughts? That sounds much better then the proposed patch. I am not really interested in changing log-levels to make test-tools happy. Joerg