From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Pan Subject: Re: [PATCH 1/1] iommu/vt-d: Fix a potential memory leak Date: Wed, 28 Feb 2018 07:10:13 -0800 Message-ID: <20180228071013.53e91c90@jacob-builder> References: <1519450947-9760-1-git-send-email-baolu.lu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1519450947-9760-1-git-send-email-baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Lu Baolu Cc: Ashok Raj , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "# v4 . 4+" , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Sat, 24 Feb 2018 13:42:27 +0800 Lu Baolu wrote: > A memory block was allocated in intel_svm_bind_mm() but never freed > in a failure path. This patch fixes this by free it to avoid memory > leakage. > looks good to me. Thanks, > Cc: Ashok Raj > Cc: Jacob Pan > Cc: # v4.4+ > Signed-off-by: Lu Baolu > --- > drivers/iommu/intel-svm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c > index 35a408d..3d4b924 100644 > --- a/drivers/iommu/intel-svm.c > +++ b/drivers/iommu/intel-svm.c > @@ -396,6 +396,7 @@ int intel_svm_bind_mm(struct device *dev, int > *pasid, int flags, struct svm_dev_ pasid_max - 1, GFP_KERNEL); > if (ret < 0) { > kfree(svm); > + kfree(sdev); > goto out; > } > svm->pasid = ret; [Jacob Pan]