From: Jeffy Chen <jeffy.chen@rock-chips.com>
To: linux-kernel@vger.kernel.org
Cc: jcliang@chromium.org, robin.murphy@arm.com, xxm@rock-chips.com,
tfiga@chromium.org, Jeffy Chen <jeffy.chen@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v6 06/14] iommu/rockchip: Fix TLB flush of secondary IOMMUs
Date: Thu, 1 Mar 2018 18:18:29 +0800 [thread overview]
Message-ID: <20180301101837.27969-7-jeffy.chen@rock-chips.com> (raw)
In-Reply-To: <20180301101837.27969-1-jeffy.chen@rock-chips.com>
From: Tomasz Figa <tfiga@chromium.org>
Due to the bug in current code, only first IOMMU has the TLB lines
flushed in rk_iommu_zap_lines. This patch fixes the inner loop to
execute for all IOMMUs and properly flush the TLB.
Signed-off-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/iommu/rockchip-iommu.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index baba283ccdf9..c4131ca792e0 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -274,19 +274,21 @@ static void rk_iommu_base_command(void __iomem *base, u32 command)
{
writel(command, base + RK_MMU_COMMAND);
}
-static void rk_iommu_zap_lines(struct rk_iommu *iommu, dma_addr_t iova,
+static void rk_iommu_zap_lines(struct rk_iommu *iommu, dma_addr_t iova_start,
size_t size)
{
int i;
-
- dma_addr_t iova_end = iova + size;
+ dma_addr_t iova_end = iova_start + size;
/*
* TODO(djkurtz): Figure out when it is more efficient to shootdown the
* entire iotlb rather than iterate over individual iovas.
*/
- for (i = 0; i < iommu->num_mmu; i++)
- for (; iova < iova_end; iova += SPAGE_SIZE)
+ for (i = 0; i < iommu->num_mmu; i++) {
+ dma_addr_t iova;
+
+ for (iova = iova_start; iova < iova_end; iova += SPAGE_SIZE)
rk_iommu_write(iommu->bases[i], RK_MMU_ZAP_ONE_LINE, iova);
+ }
}
static bool rk_iommu_is_stall_active(struct rk_iommu *iommu)
--
2.11.0
next prev parent reply other threads:[~2018-03-01 10:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 10:18 [RESEND PATCH v6 00/14] iommu/rockchip: Use OF_IOMMU Jeffy Chen
2018-03-01 10:18 ` [RESEND PATCH v6 01/14] iommu/rockchip: Prohibit unbind and remove Jeffy Chen
2018-03-01 10:18 ` [RESEND PATCH v6 02/14] iommu/rockchip: Fix error handling in probe Jeffy Chen
2018-03-01 10:18 ` [RESEND PATCH v6 03/14] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen
[not found] ` <20180301101837.27969-4-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-05 13:30 ` Tomasz Figa
2018-03-01 10:18 ` [RESEND PATCH v6 04/14] iommu/rockchip: Fix error handling in attach Jeffy Chen
2018-03-01 10:18 ` Jeffy Chen [this message]
[not found] ` <20180301101837.27969-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-01 10:18 ` [RESEND PATCH v6 05/14] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-03-01 10:18 ` [RESEND PATCH v6 08/14] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen
2018-03-01 10:18 ` [RESEND PATCH v6 09/14] dt-bindings: iommu/rockchip: Add clock property Jeffy Chen
[not found] ` <20180301101837.27969-10-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-06 2:27 ` Rob Herring
2018-03-06 2:32 ` JeffyChen
2018-03-01 10:18 ` [RESEND PATCH v6 10/14] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
2018-03-01 10:18 ` [RESEND PATCH v6 11/14] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-03-01 10:18 ` [RESEND PATCH v6 12/14] iommu/rockchip: Fix error handling in init Jeffy Chen
2018-03-01 10:18 ` [RESEND PATCH v6 13/14] iommu/rockchip: Add runtime PM support Jeffy Chen
2018-03-05 13:49 ` Tomasz Figa
[not found] ` <CAAFQd5D2SY2RV9HLTeTQigfnVCkF9wDq74_+t3OV2YEb9wJtqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-05 14:13 ` Robin Murphy
[not found] ` <0cd81b39-ffe9-eda3-1358-13afeb2ec25b-5wv7dgnIgG8@public.gmane.org>
2018-03-05 14:34 ` Tomasz Figa
2018-03-06 1:57 ` JeffyChen
2018-03-01 10:18 ` [RESEND PATCH v6 14/14] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen
[not found] ` <20180301101837.27969-15-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-01 11:03 ` Robin Murphy
[not found] ` <44efebd3-ab48-4e12-cf92-66b6563f7644-5wv7dgnIgG8@public.gmane.org>
2018-03-01 11:14 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301101837.27969-7-jeffy.chen@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jcliang@chromium.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=tfiga@chromium.org \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).