From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Fredrik Noring <noring-zgYzP9v7iJcdnm+yROfE0A@public.gmane.org>
Cc: "Jürgen Urban" <JuergenUrban-Mmb7MZpHnFY@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
"Christoph Hellwig" <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: WARN_ON(irqs_disabled()) in dma_free_attrs?
Date: Fri, 2 Mar 2018 22:37:11 +0100 [thread overview]
Message-ID: <20180302213711.GA30356@lst.de> (raw)
In-Reply-To: <20180302180704.GA3846-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On Fri, Mar 02, 2018 at 07:07:06PM +0100, Fredrik Noring wrote:
> What is the best way to proceed? Can dma_free_attrs be reworked to handle
> disabled IRQs?
Why do you want to free coherent dma allocations from irq context?
They generally are a long-term resource that as a rule of thumb should
be allocated in ->probe and freed in ->remove.
next prev parent reply other threads:[~2018-03-02 21:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 18:07 WARN_ON(irqs_disabled()) in dma_free_attrs? Fredrik Noring
[not found] ` <20180302180704.GA3846-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-03-02 19:55 ` Robin Murphy
[not found] ` <bfe85e97-2974-06ee-8c6d-f8e8a83348ea-5wv7dgnIgG8@public.gmane.org>
2018-03-02 21:47 ` Christoph Hellwig
2018-03-03 7:58 ` Fredrik Noring
2018-03-02 21:37 ` Christoph Hellwig [this message]
[not found] ` <20180302213711.GA30356-jcswGhMUV9g@public.gmane.org>
2018-03-03 8:22 ` Fredrik Noring
[not found] ` <20180303082234.GB24991-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-03-03 16:12 ` Christoph Hellwig
[not found] ` <20180303161249.GA9516-jcswGhMUV9g@public.gmane.org>
2018-03-03 18:19 ` Fredrik Noring
[not found] ` <20180303181904.GA19076-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-03-04 15:58 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1803041054540.13805-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2018-03-04 17:59 ` Fredrik Noring
[not found] ` <20180304175949.GB2368-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-03-05 2:05 ` Alan Stern
2018-03-05 15:10 ` Christoph Hellwig
[not found] ` <20180305151010.GA15965-jcswGhMUV9g@public.gmane.org>
2018-03-11 18:01 ` Fredrik Noring
[not found] ` <20180311180124.GA27731-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-03-13 12:11 ` Robin Murphy
[not found] ` <5696e17e-e0f4-4e6c-7783-4eeea0ff7a5e-5wv7dgnIgG8@public.gmane.org>
2018-03-13 13:17 ` Christoph Hellwig
[not found] ` <20180313131745.GC6260-jcswGhMUV9g@public.gmane.org>
2018-03-14 17:43 ` Robin Murphy
[not found] ` <d0659e5e-4be7-9a1e-fb8e-b418962d74de-5wv7dgnIgG8@public.gmane.org>
2018-03-15 7:58 ` Christoph Hellwig
[not found] ` <20180315075831.GB12136-jcswGhMUV9g@public.gmane.org>
2018-03-15 13:11 ` Robin Murphy
[not found] ` <dfc5505e-9ab9-2d81-2fc5-623730a68ba9-5wv7dgnIgG8@public.gmane.org>
2018-06-22 14:56 ` Fredrik Noring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302213711.GA30356@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=JuergenUrban-Mmb7MZpHnFY@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=noring-zgYzP9v7iJcdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).