From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: jroedel-l3A5Bk7waGM@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: [bug report] iommu/arm-smmu: Make use of the iommu_register interface
Date: Mon, 5 Mar 2018 17:33:02 +0300 [thread overview]
Message-ID: <20180305143302.GA6224@mwanda> (raw)
Hello Joerg Roedel,
This is a semi-automatic email about new static checker warnings.
The patch 9648cbc9625b: "iommu/arm-smmu: Make use of the
iommu_register interface" from Feb 1, 2017, leads to the following
Smatch complaint:
./drivers/iommu/arm-smmu-v3.c:1957 arm_smmu_remove_device()
warn: variable dereferenced before check 'master' (see line 1956)
./drivers/iommu/arm-smmu-v3.c
1955 master = fwspec->iommu_priv;
1956 smmu = master->smmu;
^^^^^^^^^^^^
Pach adds unchecked dereference
1957 if (master && master->ste.assigned)
^^^^^^
The old code assumes "master" can be NULL.
1958 arm_smmu_detach_dev(dev);
1959 iommu_group_remove_device(dev);
regards,
dan carpenter
next reply other threads:[~2018-03-05 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 14:33 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-15 8:36 [bug report] iommu/arm-smmu: Make use of the iommu_register interface Dan Carpenter
2017-02-22 11:00 ` Joerg Roedel
[not found] ` <20170222110042.GC4154-l3A5Bk7waGM@public.gmane.org>
2017-02-22 11:26 ` Robin Murphy
[not found] ` <96801505-0808-1ab0-8d10-2b6f22bec35f-5wv7dgnIgG8@public.gmane.org>
2017-02-22 12:17 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305143302.GA6224@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jroedel-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox