iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: Tom Lendacky <thomas.lendacky-5C7GfCeVMHo@public.gmane.org>,
	Konrad Rzeszutek Wilk
	<konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Muli Ben-Yehuda <mulix-BzGcCpaT2IbYtjvyW6yDsg@public.gmane.org>,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: [PATCH 05/14] x86/amd_gart: look at coherent_dma_mask instead of GFP_DMA
Date: Wed, 14 Mar 2018 18:52:04 +0100	[thread overview]
Message-ID: <20180314175213.20256-6-hch@lst.de> (raw)
In-Reply-To: <20180314175213.20256-1-hch-jcswGhMUV9g@public.gmane.org>

We want to phase out looking at the magic GFP_DMA flag in the dma mapping
routines, so switch the gart driver to use the coherent_dma_mask instead,
which is used to select the GFP_DMA flag in the caller.

Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
 arch/x86/kernel/amd_gart_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c
index 52e3abcf3e70..79ac6caaaabb 100644
--- a/arch/x86/kernel/amd_gart_64.c
+++ b/arch/x86/kernel/amd_gart_64.c
@@ -484,7 +484,7 @@ gart_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_addr,
 	unsigned long align_mask;
 	struct page *page;
 
-	if (force_iommu && !(flag & GFP_DMA)) {
+	if (force_iommu && dev->coherent_dma_mask > DMA_BIT_MASK(24)) {
 		flag &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32);
 		page = alloc_pages(flag | __GFP_ZERO, get_order(size));
 		if (!page)
-- 
2.14.2

  parent reply	other threads:[~2018-03-14 17:52 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 17:51 use generic dma-direct and swiotlb code for x86 V2 Christoph Hellwig
     [not found] ` <20180314175213.20256-1-hch-jcswGhMUV9g@public.gmane.org>
2018-03-14 17:52   ` [PATCH 01/14] x86: remove X86_PPRO_FENCE Christoph Hellwig
2018-03-14 17:52   ` [PATCH 02/14] x86: remove dma_alloc_coherent_mask Christoph Hellwig
2018-03-14 17:52   ` [PATCH 03/14] x86: use dma-direct Christoph Hellwig
     [not found]     ` <20180314175213.20256-4-hch-jcswGhMUV9g@public.gmane.org>
2018-03-15  8:56       ` Thomas Gleixner
2018-03-15 11:53         ` Christoph Hellwig
2018-03-15 12:53           ` Thomas Gleixner
     [not found]             ` <alpine.DEB.2.21.1803151352170.1525-ecDvlHI5BZPZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
2018-03-15 13:40               ` Christoph Hellwig
     [not found]                 ` <20180315134028.GA18074-jcswGhMUV9g@public.gmane.org>
2018-03-15 13:45                   ` Thomas Gleixner
2018-03-14 17:52   ` [PATCH 04/14] x86: use generic swiotlb_ops Christoph Hellwig
     [not found]     ` <20180314175213.20256-5-hch-jcswGhMUV9g@public.gmane.org>
2018-03-15  9:00       ` Thomas Gleixner
     [not found]         ` <alpine.DEB.2.21.1803150956300.1525-ecDvlHI5BZPZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
2018-03-15 11:54           ` Christoph Hellwig
     [not found]             ` <20180315115426.GB16210-jcswGhMUV9g@public.gmane.org>
2018-03-15 12:52               ` Thomas Gleixner
     [not found]                 ` <alpine.DEB.2.21.1803151351280.1525-ecDvlHI5BZPZikZi3RtOZ1XZhhPuCNm+@public.gmane.org>
2018-03-15 13:35                   ` Christoph Hellwig
     [not found]                     ` <20180315133530.GA17956-jcswGhMUV9g@public.gmane.org>
2018-03-15 13:48                       ` Thomas Gleixner
2018-03-14 17:52   ` Christoph Hellwig [this message]
     [not found]     ` <20180314175213.20256-6-hch-jcswGhMUV9g@public.gmane.org>
2018-03-15 17:47       ` [PATCH 05/14] x86/amd_gart: look at coherent_dma_mask instead of GFP_DMA Konrad Rzeszutek Wilk
2018-03-14 17:52   ` [PATCH 06/14] x86/amd_gart: use dma_direct_{alloc,free} Christoph Hellwig
2018-03-14 17:52   ` [PATCH 07/14] iommu/amd_iommu: " Christoph Hellwig
     [not found]     ` <20180314175213.20256-8-hch-jcswGhMUV9g@public.gmane.org>
2018-03-15 15:30       ` Joerg Roedel
2018-03-14 17:52   ` [PATCH 08/14] iommu/intel-iommu: cleanup intel_{alloc,free}_coherent Christoph Hellwig
2018-03-14 17:52   ` [PATCH 09/14] x86: remove dma_alloc_coherent_gfp_flags Christoph Hellwig
2018-03-14 17:52   ` [PATCH 10/14] set_memory.h: provide set_memory_{en,de}crypted stubs Christoph Hellwig
     [not found]     ` <20180314175213.20256-11-hch-jcswGhMUV9g@public.gmane.org>
2018-03-15 17:50       ` Konrad Rzeszutek Wilk
2018-03-14 17:52   ` [PATCH 11/14] swiotlb: remove swiotlb_set_mem_attributes Christoph Hellwig
     [not found]     ` <20180314175213.20256-12-hch-jcswGhMUV9g@public.gmane.org>
2018-03-15 17:51       ` Konrad Rzeszutek Wilk
     [not found]         ` <20180315175159.GR13391-he5eyhs8q0BAdwtm4QZOy9BPR1lH4CV8@public.gmane.org>
2018-03-15 17:54           ` Konrad Rzeszutek Wilk
2018-03-14 17:52   ` [PATCH 12/14] dma-direct: handle the memory encryption bit in common code Christoph Hellwig
2018-03-14 17:52   ` [PATCH 13/14] dma-direct: handle force decryption for dma coherent buffers " Christoph Hellwig
2018-03-14 17:52   ` [PATCH 14/14] swiotlb: remove swiotlb_{alloc,free}_coherent Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2018-03-19 10:38 use generic dma-direct and swiotlb code for x86 V3 Christoph Hellwig
     [not found] ` <20180319103826.12853-1-hch-jcswGhMUV9g@public.gmane.org>
2018-03-19 10:38   ` [PATCH 05/14] x86/amd_gart: look at coherent_dma_mask instead of GFP_DMA Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314175213.20256-6-hch@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mulix-BzGcCpaT2IbYtjvyW6yDsg@public.gmane.org \
    --cc=thomas.lendacky-5C7GfCeVMHo@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).