From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Dmitry Safonov <dima-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
Cc: 0x7f454c46-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCHv3] iommu/intel: Ratelimit each dmar fault printing
Date: Thu, 15 Mar 2018 16:28:28 +0100 [thread overview]
Message-ID: <20180315152828.GA11365@8bytes.org> (raw)
In-Reply-To: <1521124920.2686.20.camel-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
On Thu, Mar 15, 2018 at 02:42:00PM +0000, Dmitry Safonov wrote:
> But even with loop-limit we will need ratelimit each printk() *also*.
> Otherwise loop-limit will be based on time spent printing, not on
> anything else..
> The patch makes sense even with loop-limit in my opinion.
Looks like I mis-read your patch, somehow it looked to me as if you
replace all 'ratelimited' usages with a call to __ratelimit(), but you
just move 'ratelimited' into the loop, which actually makes sense.
But still, this alone is no proper fix for the soft-lockups you are
seeing.
Joerg
next prev parent reply other threads:[~2018-03-15 15:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 19:17 [PATCHv3] iommu/intel: Ratelimit each dmar fault printing Dmitry Safonov via iommu
2018-03-05 15:00 ` Dmitry Safonov
[not found] ` <1520262026.2743.4.camel-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2018-03-13 16:21 ` Dmitry Safonov via iommu
[not found] ` <20180215191729.15777-1-dima-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2018-03-15 13:46 ` Joerg Roedel
[not found] ` <20180315134649.skh2aukcmg5ud74y-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-03-15 14:13 ` Dmitry Safonov via iommu
[not found] ` <1521123183.2686.7.camel-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2018-03-15 14:22 ` Joerg Roedel
[not found] ` <20180315142253.GC5259-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-03-15 14:34 ` Dmitry Safonov via iommu
[not found] ` <1521124490.2686.16.camel-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2018-03-15 14:42 ` Dmitry Safonov via iommu
[not found] ` <1521124920.2686.20.camel-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2018-03-15 15:28 ` Joerg Roedel [this message]
[not found] ` <20180315152828.GA11365-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-03-15 15:54 ` Dmitry Safonov via iommu
2018-03-20 20:50 ` Dmitry Safonov via iommu
[not found] ` <1521579013.2686.83.camel-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org>
2018-03-29 8:50 ` Joerg Roedel
2018-03-29 13:52 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315152828.GA11365@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=0x7f454c46-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dima-nzgTgzXrdUbQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).