From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Tom Lendacky <thomas.lendacky-5C7GfCeVMHo@public.gmane.org>,
Konrad Rzeszutek Wilk
<konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Muli Ben-Yehuda <mulix-BzGcCpaT2IbYtjvyW6yDsg@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 12/14] dma-direct: handle the memory encryption bit in common code
Date: Mon, 19 Mar 2018 16:55:51 +0000 [thread overview]
Message-ID: <20180319165551.GE14916@arm.com> (raw)
In-Reply-To: <20180319160343.GA29002-jcswGhMUV9g@public.gmane.org>
On Mon, Mar 19, 2018 at 05:03:43PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 19, 2018 at 03:48:33PM +0000, Will Deacon wrote:
> > Why can't we just resolve the conflict by adding the underscores?
>
> We can solve the conflict easily that way. But that's not the point.
>
> The point is that I've been fighting hard to consolidate dma code
> given that the behavior really is common and not arch specific. And
> this one is another case like that: the fact that the non-coherent
> dma boundary is bigger than the exposed size is something that can
> easily happen elsewhere, so there is no need to duplicate a lot
> of code for that.
Fair enough, although I wouldn't say it's a *lot* of code being duplicated.
Are there other architectures working around this issue too? I couldn't
see anything in the other dma-direct.h headers.
> Nevermind that the commit should at least be three different patches:
>
> (1) revert the broken original commit
> (2) increase the dma min alignment
> (3) put the swiotlb workaround in place
I'd agree with you if this wasn't already queued and sitting in -next.
Reverting what we currently have seems a bit OTT now. Catalin?
Will
next prev parent reply other threads:[~2018-03-19 16:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 10:38 use generic dma-direct and swiotlb code for x86 V3 Christoph Hellwig
[not found] ` <20180319103826.12853-1-hch-jcswGhMUV9g@public.gmane.org>
2018-03-19 10:38 ` [PATCH 01/14] x86: remove X86_PPRO_FENCE Christoph Hellwig
2018-03-19 10:38 ` [PATCH 02/14] x86: remove dma_alloc_coherent_mask Christoph Hellwig
2018-03-19 10:38 ` [PATCH 03/14] x86: use dma-direct Christoph Hellwig
2018-03-19 10:38 ` [PATCH 04/14] x86: use generic swiotlb_ops Christoph Hellwig
2018-03-19 10:38 ` [PATCH 05/14] x86/amd_gart: look at coherent_dma_mask instead of GFP_DMA Christoph Hellwig
2018-03-19 10:38 ` [PATCH 06/14] x86/amd_gart: use dma_direct_{alloc,free} Christoph Hellwig
2018-03-19 10:38 ` [PATCH 07/14] iommu/amd_iommu: " Christoph Hellwig
2018-03-19 10:38 ` [PATCH 08/14] iommu/intel-iommu: cleanup intel_{alloc,free}_coherent Christoph Hellwig
2018-03-19 10:38 ` [PATCH 09/14] x86: remove dma_alloc_coherent_gfp_flags Christoph Hellwig
2018-03-19 10:38 ` [PATCH 10/14] set_memory.h: provide set_memory_{en,de}crypted stubs Christoph Hellwig
[not found] ` <20180319103826.12853-11-hch-jcswGhMUV9g@public.gmane.org>
2018-03-19 14:21 ` Tom Lendacky
2018-03-19 10:38 ` [PATCH 11/14] swiotlb: remove swiotlb_set_mem_attributes Christoph Hellwig
[not found] ` <20180319103826.12853-12-hch-jcswGhMUV9g@public.gmane.org>
2018-03-19 14:41 ` Tom Lendacky
2018-03-19 10:38 ` [PATCH 12/14] dma-direct: handle the memory encryption bit in common code Christoph Hellwig
[not found] ` <20180319103826.12853-13-hch-jcswGhMUV9g@public.gmane.org>
2018-03-19 14:50 ` Tom Lendacky
2018-03-19 15:19 ` Robin Murphy
[not found] ` <dd05dd14-9969-7985-826e-f440c3fc4c08-5wv7dgnIgG8@public.gmane.org>
2018-03-19 15:24 ` Christoph Hellwig
[not found] ` <20180319152442.GA27915-jcswGhMUV9g@public.gmane.org>
2018-03-19 15:37 ` Robin Murphy
[not found] ` <5316b479-7e75-d62f-6b17-b6bece55187c-5wv7dgnIgG8@public.gmane.org>
2018-03-19 15:48 ` Will Deacon
[not found] ` <20180319154832.GD14916-5wv7dgnIgG8@public.gmane.org>
2018-03-19 16:03 ` Christoph Hellwig
[not found] ` <20180319160343.GA29002-jcswGhMUV9g@public.gmane.org>
2018-03-19 16:55 ` Will Deacon [this message]
2018-03-19 18:01 ` Catalin Marinas
[not found] ` <20180319180141.w5o6lhknhd6q7ktq-+1aNUgJU5qkijLcmloz0ER/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2018-03-19 19:49 ` Christoph Hellwig
[not found] ` <20180319194930.GA3255-jcswGhMUV9g@public.gmane.org>
2018-03-20 16:23 ` Catalin Marinas
2018-03-19 10:38 ` [PATCH 13/14] dma-direct: handle force decryption for dma coherent buffers " Christoph Hellwig
[not found] ` <20180319103826.12853-14-hch-jcswGhMUV9g@public.gmane.org>
2018-03-19 14:51 ` Tom Lendacky
2018-03-19 10:38 ` [PATCH 14/14] swiotlb: remove swiotlb_{alloc,free}_coherent Christoph Hellwig
2018-03-19 14:00 ` use generic dma-direct and swiotlb code for x86 V3 Tom Lendacky
2018-03-19 14:56 ` Thomas Gleixner
2018-03-19 15:27 ` Konrad Rzeszutek Wilk
2018-03-19 15:28 ` Christoph Hellwig
[not found] ` <20180319152840.GA28041-jcswGhMUV9g@public.gmane.org>
2018-03-20 8:37 ` Ingo Molnar
[not found] ` <20180320083751.nrpt64dsmpqbhzc6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-03-20 8:44 ` Christoph Hellwig
[not found] ` <20180320084412.GA16337-jcswGhMUV9g@public.gmane.org>
2018-03-20 9:03 ` Ingo Molnar
[not found] ` <20180320090351.2qnwcsauhodrqxdj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-03-20 11:25 ` Konrad Rzeszutek Wilk
[not found] ` <CAPbh3rspsGE3i=WzxC4DL=EDTEbhVZVb29j-fyhAXZRwk=Xncg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-03-20 15:16 ` Christoph Hellwig
[not found] ` <20180320151600.GA23920-jcswGhMUV9g@public.gmane.org>
2018-03-21 14:32 ` Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2018-03-14 17:51 use generic dma-direct and swiotlb code for x86 V2 Christoph Hellwig
[not found] ` <20180314175213.20256-1-hch-jcswGhMUV9g@public.gmane.org>
2018-03-14 17:52 ` [PATCH 12/14] dma-direct: handle the memory encryption bit in common code Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319165551.GE14916@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mulix-BzGcCpaT2IbYtjvyW6yDsg@public.gmane.org \
--cc=thomas.lendacky-5C7GfCeVMHo@public.gmane.org \
--cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).