From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan via iommu Subject: Re: [PATCH 08/13] arch: define the ARCH_DMA_ADDR_T_64BIT config symbol in lib/Kconfig Date: Wed, 2 May 2018 23:09:34 +0100 Message-ID: <20180502220933.GB20766@jamesdev> References: <20180425051539.1989-1-hch@lst.de> <20180425051539.1989-9-hch@lst.de> Reply-To: James Hogan Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1923251509981083835==" Return-path: In-Reply-To: <20180425051539.1989-9-hch-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Hellwig Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, sstabellini-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Konrad Rzeszutek Wilk , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org --===============1923251509981083835== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wzJLGUyc3ArbnUjN" Content-Disposition: inline --wzJLGUyc3ArbnUjN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 25, 2018 at 07:15:34AM +0200, Christoph Hellwig wrote: > Define this symbol if the architecture either uses 64-bit pointers or the > PHYS_ADDR_T_64BIT is set. This covers 95% of the old arch magic. We only > need an additional select for Xen on ARM (why anyway?), and we now always > set ARCH_DMA_ADDR_T_64BIT on mips boards with 64-bit physical addressing > instead of only doing it when highmem is set. I think this should be fine. It only affects alchemy and Netlogic, and Netlogic supports highmem already. So for MIPS: Acked-by: James Hogan Cheers James > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 985388078872..e10cc5c7be69 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -1101,9 +1101,6 @@ config GPIO_TXX9 > config FW_CFE > bool > =20 > -config ARCH_DMA_ADDR_T_64BIT > - def_bool (HIGHMEM && PHYS_ADDR_T_64BIT) || 64BIT > - > config ARCH_SUPPORTS_UPROBES > bool > diff --git a/lib/Kconfig b/lib/Kconfig > index ce9fa962d59b..1f12faf03819 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -435,6 +435,9 @@ config NEED_SG_DMA_LENGTH > config NEED_DMA_MAP_STATE > bool > =20 > +config ARCH_DMA_ADDR_T_64BIT > + def_bool 64BIT || PHYS_ADDR_T_64BIT > + > config IOMMU_HELPER > bool --wzJLGUyc3ArbnUjN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQS7lRNBWUYtqfDOVL41zuSGKxAj8gUCWuo3DwAKCRA1zuSGKxAj 8tikAQDi/ZUNjW7+epg5yVcHFsdN4zPqszjMfOoZb9Tw0/w5/QD+O0gHySriLqfv vZwnsvl5Mx2kzMLvdMNqFC++weR4XwQ= =H1g4 -----END PGP SIGNATURE----- --wzJLGUyc3ArbnUjN-- --===============1923251509981083835== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============1923251509981083835==--