From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Xu Subject: Re: [PATCH v2 2/3] intel-iommu: generalize __mapping_notify_one() Date: Fri, 4 May 2018 10:23:52 +0800 Message-ID: <20180504022352.GK29580@xz-mi> References: <20180418083953.21492-1-peterx@redhat.com> <20180418083953.21492-3-peterx@redhat.com> <20180503131424.jsn4qvfuwur7adcb@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180503131424.jsn4qvfuwur7adcb-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: Linux IOMMU Mailing List , Linux Kernel Mailing List , Alexander Witte , David Woodhouse , Jintack Lim List-Id: iommu@lists.linux-foundation.org On Thu, May 03, 2018 at 03:14:24PM +0200, Joerg Roedel wrote: > On Wed, Apr 18, 2018 at 04:39:52PM +0800, Peter Xu wrote: > > Generalize this new helper to notify one newly created mapping on one > > single IOMMU. We can further leverage this helper in the next patch. > > You introduce the function, you do not generalize it. Please fix that in > the subject and description. > > Also, please drop patch 1, I don't like this pr_debug stuff in the > code. And please also fix the subject line in general to match the form: > > iommu/vt-d: _I_ntroduce __mapping_notify_one() > > When that is done, please re-send. Will do. Thanks, Joerg. -- Peter Xu