From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Finn Thain
<fthain-PnMVE5gNl/W9dxLkCovUHLpzq4S04n8Q@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
linux-m68k-cunTk1MwBs8S/qaLPR03pWD2FQJk+8+b@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
Greg Ungerer <gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
Joshua Thompson <funaho-E7XWuSn13XjYtjvyW6yDsg@public.gmane.org>
Subject: Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet
Date: Mon, 28 May 2018 07:33:38 +0200 [thread overview]
Message-ID: <20180528053338.GA3195@lst.de> (raw)
In-Reply-To: <20180527041505.GB31985-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
On Sat, May 26, 2018 at 09:15:05PM -0700, Guenter Roeck wrote:
> Good point. Maybe it would be better to limit the warning to SMP systems
> instead of (unnecessarily) fixing drivers all over the place ?
No. The coherent_dma_mask is the mask used for dma_alloc_coherent and
dma_alloc_attrs. It has nothing to do with cache coherent in SMP
systems.
prev parent reply other threads:[~2018-05-28 5:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527378785-13326-1-git-send-email-linux@roeck-us.net>
[not found] ` <alpine.LNX.2.21.1805271212480.9@nippy.intranet>
[not found] ` <alpine.LNX.2.21.1805271212480.9-i19888lE8tflDoPlx7XIcw@public.gmane.org>
2018-05-27 4:15 ` [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet Guenter Roeck
[not found] ` <20180527041505.GB31985-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2018-05-28 5:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528053338.GA3195@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=fthain-PnMVE5gNl/W9dxLkCovUHLpzq4S04n8Q@public.gmane.org \
--cc=funaho-E7XWuSn13XjYtjvyW6yDsg@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=gerg-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-m68k-cunTk1MwBs8S/qaLPR03pWD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).