From: Christoph Hellwig <hch@infradead.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: nouveau@lists.freedesktop.org, Joerg Roedel <joro@8bytes.org>,
Russell King <linux@armlinux.org.uk>,
dri-devel@lists.freedesktop.org,
Christoph Hellwig <hch@infradead.org>,
Jordan Crouse <jcrouse@codeaurora.org>,
iommu@lists.linux-foundation.org, Ben Skeggs <bskeggs@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>,
linux-tegra@vger.kernel.org, Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] drm/nouveau: tegra: Detach from ARM DMA/IOMMU mapping
Date: Thu, 31 May 2018 09:12:47 -0700 [thread overview]
Message-ID: <20180531161247.GA10203@infradead.org> (raw)
In-Reply-To: <20180530140625.21247-3-thierry.reding@gmail.com>
> +#if IS_ENABLED(CONFIG_ARM_DMA_USE_IOMMU)
> + if (dev->archdata.mapping) {
> + struct dma_iommu_mapping *mapping = to_dma_iommu_mapping(dev);
> +
> + arm_iommu_detach_device(dev);
> + arm_iommu_release_mapping(mapping);
> + }
> +#endif
Having this hidden in a helper would be nicer, but anything that
doesn't directly expose the dma_map_ops to a driver is fine with me.
So from the dma-mapping POV:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-05-31 16:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 14:06 [PATCH v4 0/2] drm/nouveau: tegra: Detach from ARM DMA/IOMMU mapping Thierry Reding
[not found] ` <20180530140625.21247-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-05-30 14:06 ` [PATCH v4 1/2] ARM: dma-mapping: Set proper DMA ops in arm_iommu_detach_device() Thierry Reding
2018-05-31 17:52 ` Robin Murphy
[not found] ` <20180530140625.21247-2-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-07-02 11:53 ` Thierry Reding
2018-07-02 15:23 ` Russell King - ARM Linux
2018-07-02 15:34 ` Christoph Hellwig
2018-05-30 14:06 ` [PATCH v4 2/2] drm/nouveau: tegra: Detach from ARM DMA/IOMMU mapping Thierry Reding
2018-05-31 16:12 ` Christoph Hellwig [this message]
[not found] ` <20180530140625.21247-3-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-05-31 17:56 ` Robin Murphy
2018-07-06 15:36 ` Nicolas Chauvet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531161247.GA10203@infradead.org \
--to=hch@infradead.org \
--cc=bskeggs@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jcrouse@codeaurora.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nouveau@lists.freedesktop.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).