From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH] iommu/amd: fix missing tag from dev_err message Date: Fri, 6 Jul 2018 15:00:24 +0200 Message-ID: <20180706130024.GD13903@8bytes.org> References: <1540588259.84011.1530637026831@ox-groupware.bfs.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joe Perches Cc: "Hook, Gary" , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Colin Ian King , Walter Harms List-Id: iommu@lists.linux-foundation.org On Tue, Jul 03, 2018 at 10:34:12AM -0700, Joe Perches wrote: > On Tue, 2018-07-03 at 18:57 +0200, Walter Harms wrote: > > It is only cosmetics but even the author got lost about the loose bracket. > > I would suggest to remove all the brackets or if needed to move the [ in the > > message. We have enought memory this days. > > My suggestion would be to remove the separate dev_err > and use "Event log [" in each dev_err. > > So here's an actual suggested patch that does a few things: > > o Coalesce formats and realigns arguments > o Uses pr_fmt and dev_fmt to prefix "AMD-Vi: " to all messages > o Remove embedded "AMD-Vi: " from various formats Nice cleanup! But I got lost a bit in the patches floating around in this thread and their dependencies. Can someone sort it out and send it a new patch-set to me? Thanks, Joerg