From: Richard Kuo <rkuo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: linux-hexagon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] hexagon: remove the sync_single_for_cpu DMA operation
Date: Tue, 24 Jul 2018 22:29:48 -0500 [thread overview]
Message-ID: <20180725032948.GG12771@codeaurora.org> (raw)
In-Reply-To: <20180719125635.824-2-hch-jcswGhMUV9g@public.gmane.org>
On Thu, Jul 19, 2018 at 05:56:33AM -0700, Christoph Hellwig wrote:
> hexagon does all the required cache maintainance at dma map time, and none
> at unmap time. It thus has to implement sync_single_for_device to match
> the map cace for buffer reuse, but there is no point in doing another
> invalidation in the sync_single_cpu_case, which in terms of cache
> maintainance is equivalent to the unmap case.
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> ---
> arch/hexagon/kernel/dma.c | 8 --------
> 1 file changed, 8 deletions(-)
>
Patch series looks good. Definitely appreciate the cleanup.
I can take it through my tree, or if not:
Acked-by: Richard Kuo <rkuo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Thanks!
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-07-25 3:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 12:56 use the generic dma-noncoherent code for hexagon Christoph Hellwig
2018-07-19 12:56 ` [PATCH 1/3] hexagon: remove the sync_single_for_cpu DMA operation Christoph Hellwig
[not found] ` <20180719125635.824-2-hch-jcswGhMUV9g@public.gmane.org>
2018-07-25 3:29 ` Richard Kuo [this message]
[not found] ` <20180725032948.GG12771-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-07-25 4:39 ` Christoph Hellwig
2018-07-31 15:22 ` Christoph Hellwig
[not found] ` <20180731152229.GA956-jcswGhMUV9g@public.gmane.org>
2018-08-07 7:01 ` Christoph Hellwig
[not found] ` <20180807070136.GA32634-jcswGhMUV9g@public.gmane.org>
2018-08-08 0:19 ` Richard Kuo
2018-08-08 6:19 ` Christoph Hellwig
2018-08-27 8:41 ` Christoph Hellwig
2018-07-19 12:56 ` [PATCH 2/3] hexagon: implement the sync_sg_for_device " Christoph Hellwig
2018-07-19 12:56 ` [PATCH 3/3] hexagon: use generic dma_noncoherent_ops Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725032948.GG12771@codeaurora.org \
--to=rkuo-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-hexagon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).