From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Kuo Subject: Re: [PATCH 1/3] hexagon: remove the sync_single_for_cpu DMA operation Date: Tue, 24 Jul 2018 22:29:48 -0500 Message-ID: <20180725032948.GG12771@codeaurora.org> References: <20180719125635.824-1-hch@lst.de> <20180719125635.824-2-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180719125635.824-2-hch-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Hellwig Cc: linux-hexagon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Thu, Jul 19, 2018 at 05:56:33AM -0700, Christoph Hellwig wrote: > hexagon does all the required cache maintainance at dma map time, and none > at unmap time. It thus has to implement sync_single_for_device to match > the map cace for buffer reuse, but there is no point in doing another > invalidation in the sync_single_cpu_case, which in terms of cache > maintainance is equivalent to the unmap case. > > Signed-off-by: Christoph Hellwig > --- > arch/hexagon/kernel/dma.c | 8 -------- > 1 file changed, 8 deletions(-) > Patch series looks good. Definitely appreciate the cleanup. I can take it through my tree, or if not: Acked-by: Richard Kuo Thanks! -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project