From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC PATCH 2/3] dma-mapping: clear dma_ops pointer also on ARM Date: Fri, 14 Sep 2018 15:12:04 +0200 Message-ID: <20180914131204.GA27141@lst.de> References: <20180913151716.6333-1-wsa+renesas@sang-engineering.com> <20180913151716.6333-3-wsa+renesas@sang-engineering.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180913151716.6333-3-wsa+renesas@sang-engineering.com> Sender: linux-kernel-owner@vger.kernel.org To: Wolfram Sang Cc: iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , linux-renesas-soc@vger.kernel.org, Marek Szyprowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: iommu@lists.linux-foundation.org On Thu, Sep 13, 2018 at 05:17:15PM +0200, Wolfram Sang wrote: > The generic fallback of arch_teardown_dma_ops() clears the dma_ops > pointer but the ARM specific version does not. Rename the generic one, > so it can be called from ARM specific one, too. This will ensure > consistent behaviour. Hmm. I'd rather remove your new generic version entirely and move the ops clearing into the two callers.