From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Pan Subject: Re: [PATCH v3 01/10] iommu: Introduce Shared Virtual Addressing API Date: Tue, 25 Sep 2018 15:46:42 -0700 Message-ID: <20180925154642.18a98849@jacob-builder> References: <20180920170046.20154-1-jean-philippe.brucker@arm.com> <20180920170046.20154-2-jean-philippe.brucker@arm.com> <20180925131647.rygncwik5uszsm3n@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180925131647.rygncwik5uszsm3n-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Jean-Philippe Brucker , kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org, ilias.apalodimas-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, liguozhu-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, christian.koenig-5C7GfCeVMHo@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Tue, 25 Sep 2018 15:16:47 +0200 Joerg Roedel wrote: > On Sun, Sep 23, 2018 at 10:39:25AM +0800, Lu Baolu wrote: > > > +int iommu_sva_init_device(struct device *dev, unsigned long > > > features, > > > + unsigned int min_pasid, unsigned int > > > max_pasid) +{ > > > + int ret; > > > + struct iommu_sva_param *param; > > > + struct iommu_domain *domain = > > > iommu_get_domain_for_dev(dev); > > > > This doesn't work for vt-d. The domains for host iova are > > self-managed by vt-d driver itself. Hence, > > iommu_get_domain_for_dev() will always return NULL unless an > > UNMANAGED domain is attached to the device. > > > > How about > > > > const struct iommu_ops *ops = dev->bus->iommu_ops; > > > > instead? > > The per-bus iommu-ops might go away sooner or later as we move to > per-device iommu-ops. How about fixing the VT-d driver to not keep > that domain internal to itself? > Just to understand more specifically, you mean let VT-d driver also support IOMMU_DOMAIN_DMA as default domain? But I think the ordering issue is still there in that the DOMAIN_DMA domain will not be created until DMA map call is invoked. I think sva_init_device should not depend on the default domain. > Regards, > > Joerg [Jacob Pan]