From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 7/7] vfio/type1: Remove map_try_harder() code path Date: Thu, 15 Nov 2018 16:55:22 +0100 Message-ID: <20181115155522.ukxnskxiqcoqxw3d@8bytes.org> References: <20181109110712.12469-1-joro@8bytes.org> <20181109110712.12469-8-joro@8bytes.org> <20181109092329.79b0fe91@t450s.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20181109092329.79b0fe91-1yVPhWWZRC1BDLzU/O5InQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Alex Williamson Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, jroedel-l3A5Bk7waGM@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hi Alex, On Fri, Nov 09, 2018 at 09:23:29AM -0700, Alex Williamson wrote: > Cool, glad to see this finally fixed. My "should be fixed soon" > comment turned out to be a little optimistic with the fix finally > coming 5 years later. We could of course keep this code as it really > doesn't harm anything, but I'm in favor trying to remove it if we think > it's dead now. Yeah, it took a while to fix that :) And we can easily revert this patch if it turns out someone else is also relying on the workaround. > In order to expedite into one pull: > > Acked-by: Alex Williamson Thanks a lot. I've queued these patches into my tree now. Regards, Joerg