Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()

["Niklas Söderlund" <niklas.soderlund-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>]

On 2018-11-02 11:22:54 +0100, Niklas Söderlund wrote:
> Hi,
> 
> A gentle ping on this patch.

A slightly harder ping :-)

> 
> On 2018-08-29 23:29:21 +0200, Niklas Söderlund wrote:
> > The function dma_set_max_seg_size() can return either 0 on success or
> > -EIO on error. Change its return type from unsigned int to int to
> > capture this.
> > 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> >  include/linux/dma-mapping.h | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> > index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
> > --- a/include/linux/dma-mapping.h
> > +++ b/include/linux/dma-mapping.h
> > @@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
> >  	return SZ_64K;
> >  }
> >  
> > -static inline unsigned int dma_set_max_seg_size(struct device *dev,
> > -						unsigned int size)
> > +static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
> >  {
> >  	if (dev->dma_parms) {
> >  		dev->dma_parms->max_segment_size = size;
> > -- 
> > 2.18.0
> > 
> 
> -- 
> Regards,
> Niklas Söderlund

-- 
Regards,
Niklas Söderlund